fix(cli): handle url imports for themer.sanity.build #11346
Merged
+218
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
Contributor
🧪 E2E Preview environment🔑 Environment Variables for Local TestingThis is the preview URL for the E2E tests: https://e2e-studio-l6gbbx53p.sanity.dev To run the E2E tests locally, you can use the following environment variables, then run 💬 Remember to build the project first with |
Contributor
📊 Playwright Test ReportThis report contains test results, including videos of failing tests. |
Contributor
⚡️ Editor Performance ReportDeploying studio and running performance tests… |
1 similar comment
Contributor
⚡️ Editor Performance ReportDeploying studio and running performance tests… |
Contributor
Coverage Report
File CoverageNo changed files found. |
kbrabrand
force-pushed
the
cldx-2705/themer-http-import-fix
branch
from
018fcf3 to
2f3de31
Compare
kbrabrand
force-pushed
the
cldx-2705/themer-http-import-fix
branch
from
48af160 to
20cea3b
Compare
Contributor
Author
Cool. I need an approval to be able to merge :) (running the eFPS tests again before merging ofc.. they failed as per usual) |
kbrabrand
force-pushed
the
cldx-2705/themer-http-import-fix
branch
from
20cea3b to
a5ac793
Compare
kbrabrand
force-pushed
the
cldx-2705/themer-http-import-fix
branch
from
a5ac793 to
60a7c05
Compare
bjoerge
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR adds an override for imports starting with
https://themer.sanity.build/api/that returns aProxyobject. This should be safe since the themes from the themer never impacts the exported schema.This was done in response to https://linear.app/sanity/issue/CLDX-2705/validateextract-schema-fails-when-there-is-a-url-import-in reported by a user in #7602.
Testing
Tests have been added both for the
importErrorHandlerin isolation and a test verifying that the themer url imports work in a worker where themockBrowserEnvironmentis called. Has also been verified in a test project locally.Notes for release
sanity.config.ts#7602)